Skip to content

feat(trace): Only allow zip files to be selected for upload #37905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2025
Merged

feat(trace): Only allow zip files to be selected for upload #37905

merged 3 commits into from
Oct 20, 2025

Conversation

@cpAdm
Copy link
Contributor

@cpAdm cpAdm commented Oct 17, 2025 •
edited
Loading

Reflect the change that the trace viewer only allows 1 trace at same time and let user only select zip files.

Before:
image

After:
image

Closes: #37933

pavelfeldman
pavelfeldman reviewed Oct 17, 2025
View reviewed changes
pavelfeldman
pavelfeldman reviewed Oct 20, 2025
View reviewed changes
@pavelfeldman
Copy link
Member

pavelfeldman commented Oct 20, 2025

For potentially breaking changes, we should definitely start with an issue

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@cpAdm cpAdm mentioned this pull request Oct 20, 2025
Closed
@cpAdm
Copy link
Contributor Author

cpAdm commented Oct 20, 2025

For potentially breaking changes, we should definitely start with an issue

Good point, created: #37933

@pavelfeldman pavelfeldman reopened this Oct 20, 2025
@cpAdm cpAdm requested a review from pavelfeldman October 20, 2025 21:39
@pavelfeldman
Copy link
Member

pavelfeldman commented Oct 20, 2025

@microsoft-github-policy-service rerun

@pavelfeldman pavelfeldman merged commit 3978aab into microsoft:main Oct 20, 2025
33 of 35 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Test results for "MCP"

2635 passed, 108 skipped

Merge workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:245 › should not preserve selection across test runs @macos-latest-node18-1

2 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node18`
⚠️ [firefox-page] › page/page-event-request.spec.ts:182 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node18`

47144 passed, 815 skipped

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: Only allow zip files to be selected for upload

2 participants

@cpAdm @pavelfeldman